fix buildLockKey failed #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: charlie <[email protected]>
Charlie17Li
force-pushed
the
fix/buildKey
branch
from
7a51b01 to
d964209
Compare
Signed-off-by: charlie <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #497 +/- ##
==========================================
- Coverage 39.05% 39.03% -0.03%
==========================================
Files 152 152
Lines 10218 10225 +7
==========================================
Hits 3991 3991
- Misses 5905 5912 +7
Partials 322 322
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
106umao
approved these changes
Mar 10, 2023
luky116
approved these changes
Mar 13, 2023
georgehao
pushed a commit
to georgehao/seata-go
that referenced
this pull request
May 7, 2023
sort before get column name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #496
Special notes for your reviewer:
太长不看版
TableMeta 中获取的 PrimaryKey的 columns 顺序和实际 data 中 PrimaryKey 的 columns 顺序不一致导致类型转换发生错误
详细分析版
buildLockKey是用来生成 LockKey, 函数会扫描每一行并仅取出primarykey，然后以此拼成LockKeyDoes this PR introduce a user-facing change?: